feat(Flyover): export a static QA atlas - #270
Open
kyleve wants to merge 18 commits into
Open
Conversation
kyleve
commented
Aug 14, 2026
| /// Throws when a settle phase cannot produce a trustworthy capture. | ||
| @MainActor | ||
| func reportIfUnsettled( | ||
| func throwIfUnsettled( |
Owner
Author
There was a problem hiding this comment.
Review focus: this deliberately changes unsettled and starved captures from recorded test issues followed by image generation into typed throws. assertSnapshots still records the thrown error, while the new hosted PNG caller stops immediately and cannot publish that image. Cancellation now follows the same path through CancellationError.
Make the atlas canvas-first with a compact floating dock, command-palette navigation, grouped list rows, and an immersive screenshot inspector. Preserve manifest and deep-link compatibility while keeping secondary review tools available in focused panels.\n\nValidation:\n- ./flyover export --output /tmp/where-flyover-codex --profile phone-light\n- ./test FlyoverTests\n- bash Shared/Flyover/Tools/Tests/flyover_test.sh\n- ./swiftformat --lint\n- JavaScriptCore syntax parse
Resolve the command-runner extraction while preserving Flyover export progress. Adapt accessibility preparation to main's throwing settle behavior.
Run the Flyover shell self-test when its module fixture is present. Keep extracted test-runner contract fixtures independent of module-specific files.
kyleve
commented
Sep 7, 2026
| ) | ||
| } | ||
|
|
||
| private var profileSize: CGSize { |
Owner
Author
There was a problem hiding this comment.
Is this duplicated from anywhere?
…qa-atlas # Conflicts: # Shared/SnapshotKitTesting/TODOs.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./flyover exportto generate a portable, network-free Where QA atlas from native simulator captures../flyover previewto validate and serve an atlas with a printed loopback or LAN URL.--profileflags select only the requested profiles, preserve order, and remove duplicates.WhereFlyoverWorld.Product behavior
/or Command-K. It finds groups, screens, states, and routes and moves focus to a visible result.Correctness and native parity
Periscope.shared. Web export receives the synthetic world's isolated log system, so export does not read user or process data.manifest.jsparity before publication.Architecture
Tools/flyover_manifest.pyowns manifest and artifact validation.Tools/flyover_preview.pyowns only the HTTP server and command lifecycle.fetch, packages, remote fonts, analytics, or external scripts.Measured Where artifact
A fresh
phone-lightexport from this branch contains 5 groups, 51 screens, 112 named states, 42 routes, 112 native captures, and 112 thumbnails. The artifact is 111,456,279 bytes and completed in 129 seconds, including wrapper validation, project generation, build, hosted capture, and publication.For the default state of all 51 screens, decoded thumbnail pixels require about 88 MiB versus about 720 MiB for the native captures, an 8.2× reduction. The browser still loads every visible card or row.
The counts are derived from the current catalog. No exporter constant stores them.
Compatibility
The feature is DEBUG-only and test-only. It changes no production data, backup, persistence, or release runtime behavior.
schemaVersion: 1remains the artifact boundary.Testing
./test --everything— 2,040 main iOS tests and 51 snapshot tests passed../test --only 'WhereUISnapshotTests/WhereFlyoverWebExportTests/exportsHostedSmokeAtlas()'— the exact hosted smoke matrix passed.PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s Tools/Tests -p 'test_*.py'— 81 tests passed.Shared/Flyover/Tools/Tests/flyover_test.sh— export/preview command behavior and the executable browser harness passed../shellcheck./swiftformat --lintbash -n flyover test Shared/Flyover/Tools/Tests/flyover_test.shgit diff --check./flyover export --output /tmp/where-flyover-final-e81c --profile phone-light— 51 screens, 112 states, 42 routes, and 112 valid native PNGs plus thumbnails.